Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 )
Change subject: KUDU-2148: do not crash on GetStatus during server startup ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9041/4/src/kudu/server/rpc_server.cc File src/kudu/server/rpc_server.cc: http://gerrit.cloudera.org:8080/#/c/9041/4/src/kudu/server/rpc_server.cc@213 PS4, Line 213: return Status::IllegalState(Substitute("bad state: $0", server_state_)); > I think this might be better as ServiceUnavailable, since it's expected to I was trying to be consistent with Webserver::GetBoundAddresses, which returns IllegalState. But I suppose I can update both. -- To view, visit http://gerrit.cloudera.org:8080/9041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b997999d8a1228244e0be0ea61705f2c12e3426 Gerrit-Change-Number: 9041 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 18 Jan 2018 00:28:04 +0000 Gerrit-HasComments: Yes
