Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 )
Change subject: Add unsigned-integer overflow checking to UBSAN ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6637/4/src/kudu/gutil/port.h File src/kudu/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/6637/4/src/kudu/gutil/port.h@425 PS4, Line 425: #if defined(__SANITIZE_ADDRESS__) || defined(ADDRESS_SANITIZER) > hrm, so this only will trigger if ASAN is _enabled_, not _available_. So if Ah ok I misunderstood. I've changed it to use has_feature. This version did indeed break all of the tests. -- To view, visit http://gerrit.cloudera.org:8080/6637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0712f5307dcbab7fdffbe2364e1fdb691d3aaab Gerrit-Change-Number: 6637 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 18 Jan 2018 19:55:24 +0000 Gerrit-HasComments: Yes
