Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/6637 )
Change subject: Add unsigned-integer overflow checking to UBSAN ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6637/3/src/kudu/gutil/port.h File src/kudu/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/6637/3/src/kudu/gutil/port.h@424 PS3, Line 424: #if defined(__llvm__) gcc >=4.9 also has UBSAN I believe. Perhaps we should has has_feature(address_sanitizer) as a proxy? (I think all versions with UBSAN also have ASAN, and at least the attribute should be valid?) -- To view, visit http://gerrit.cloudera.org:8080/6637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0712f5307dcbab7fdffbe2364e1fdb691d3aaab Gerrit-Change-Number: 6637 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 18 Jan 2018 18:00:02 +0000 Gerrit-HasComments: Yes
