Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 )
Change subject: WIP [master] no half-baked responses on ConnectoToMaster ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9052/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/9052/2/src/kudu/master/master_service.cc@463 PS2, Line 463: // Do not send half-baked responses from leader master when its catalog : // manager is not in proper state yet. Are you sure that's not by design? Todd added ConnectToMaster and I think the intent was for it to always "succeed" and supply enough information to explain the state the master was in. http://gerrit.cloudera.org:8080/#/c/9052/2/src/kudu/master/master_service.cc@488 PS2, Line 488: // TODO(KUDU-1924): it seems there is some window when 'role' is LEADER but This comment seems relevant. -- To view, visit http://gerrit.cloudera.org:8080/9052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c906863f5f0e1995041281b122135e1b2cd3a4 Gerrit-Change-Number: 9052 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 18 Jan 2018 21:24:11 +0000 Gerrit-HasComments: Yes