Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 )
Change subject: WIP [master] no half-baked responses on ConnectoToMaster ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9052/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/9052/2/src/kudu/master/master_service.cc@463 PS2, Line 463: // Do not send half-baked responses from leader master when its catalog : // manager is not in proper state yet. > So it seems like we thought we had a world with the two states { FOLLOWER, I think that makes sense, and some time ago there was a patch which did something similar: https://gerrit.cloudera.org/#/c/6356/ I think I'll do like you suggested. I think that's a good idea especially given the fact that the clients are supposed to handle such cases. Thanks! http://gerrit.cloudera.org:8080/#/c/9052/2/src/kudu/master/master_service.cc@488 PS2, Line 488: // TODO(KUDU-1924): it seems there is some window when 'role' is LEADER but > Hmm, but the message is consistent with the bug you're addressing ("a short Sorry about being fuzzy. Agreed, that's confusing. Maybe, I should handle KUDU-1924 in this commit as well. Basically, I think we can apply your idea here as well: send the role of the server as FOLLOWER in the response if this current leader doesn't have proper CA cert or TSK yet. BTW, the correct code will make the process crash if leader_status.ok() but the CA cert hasn't been set yet. That's because of CHECK() in the MasterCertAuthority::ca_cert_der() method. -- To view, visit http://gerrit.cloudera.org:8080/9052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c906863f5f0e1995041281b122135e1b2cd3a4 Gerrit-Change-Number: 9052 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2018 23:18:41 +0000 Gerrit-HasComments: Yes
