Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 )
Change subject: KUDU-2262: allow Java client to retry if no master is a leader ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9088/1/java/kudu-client/src/main/java/org/apache/kudu/client/NotAuthorizedException.java File java/kudu-client/src/main/java/org/apache/kudu/client/NotAuthorizedException.java: http://gerrit.cloudera.org:8080/#/c/9088/1/java/kudu-client/src/main/java/org/apache/kudu/client/NotAuthorizedException.java@23 PS1, Line 23: /** : * Exception indicating that the request failed because is not authorized. : * This is a recoverable exception. So the request can be retried as long : * as the original call hasn't timed out, for cases documented in KUDU-2267, : * e.g. masters are in the process of leader election and does not have : * CA signed cert. : */ : @InterfaceAudience.Private : @InterfaceStability.Evolving : final class NotAuthorizedException extends RecoverableException { I think it's not a very good idea to retry in case if a client gets not authorized response from master: imagine a case when a client does not have proper credentials due to some configuration issue. In that case, it's better to report on such issue right away: the 'fail fast' approach looks more appropriate here. Maybe, it's better to address that somehow to retry and include a call to all the registered masters instead? In that case we just need to make sure we received a response with from a leader master. -- To view, visit http://gerrit.cloudera.org:8080/9088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia39a8d77cbf58c6f2f1f97eaf5e2e17ac1fa09fa Gerrit-Change-Number: 9088 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 23 Jan 2018 19:51:37 +0000 Gerrit-HasComments: Yes
