Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 )
Change subject: KUDU-2262: allow Java client to retry if no master is a leader ...................................................................... Patch Set 1: (8 comments) Just some nits on the description of the patch. http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@10 PS1, Line 10: cause nit: causes http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: a nit: drop http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: selection nit: election http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: even nit: even if http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: were nit: are http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: leader I think that can happen only during the very first leader election after masters have been started up, right? During second and next elections, at least one master should have CA-signed TLS server certificate, right? http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@12 PS1, Line 12: tokens nit: token http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@16 PS1, Line 16: This patch makes NOT_AUTHORIZED a recoverable exception and retry the : request as long as the original call has not timed out. Corresponding : test is added in TestSecurity. Could you update this piece to reflect the actual logic of the code (as in the latest revision)? -- To view, visit http://gerrit.cloudera.org:8080/9088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia39a8d77cbf58c6f2f1f97eaf5e2e17ac1fa09fa Gerrit-Change-Number: 9088 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2018 19:49:19 +0000 Gerrit-HasComments: Yes
