David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 )
Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9093/1/src/kudu/consensus/log_cache.h File src/kudu/consensus/log_cache.h: http://gerrit.cloudera.org:8080/#/c/9093/1/src/kudu/consensus/log_cache.h@186 PS1, Line 186: // An ordered map that serves as the buffer for the cached messages. : // Maps from log index -> ReplicateMsg : struct Entry { : ReplicateRefPtr msg; : int64_t mem_usage; : }; : typedef std::map<uint64_t, Entry> MessageCache; nit: maybe rename to CacheEntry? also consider moving the declaration to LOC 151, as this would help in understanding the argument of AccountForMessageRemoval() (though admittedly that's made a bit moot with the rename) -- To view, visit http://gerrit.cloudera.org:8080/9093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0439995fb1369a3333b7d5858518d01277b53076 Gerrit-Change-Number: 9093 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 23 Jan 2018 21:40:29 +0000 Gerrit-HasComments: Yes
