Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 )
Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9093/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9093/3//COMMIT_MSG@9 PS3, Line 9: The SpaceUsed function appears to be somewhat expensive since it walks Did you consider using MessageLite::GetCachedSize in the hot path? -- To view, visit http://gerrit.cloudera.org:8080/9093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0439995fb1369a3333b7d5858518d01277b53076 Gerrit-Change-Number: 9093 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2018 19:25:42 +0000 Gerrit-HasComments: Yes
