Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9092 )
Change subject: consensus: avoid extra thread wakeups for Peer::SignalRequest ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9092/2/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: http://gerrit.cloudera.org:8080/#/c/9092/2/src/kudu/consensus/consensus_peers.cc@172 PS2, Line 172: request_pending_ > worth it to add an exception for "even_if_queue_empty"? thinking of TOCTOU, It's possible that it changes, but since this isn't synchronized against the change as is, then it's always possible that this current code would submit the task, and the task would run before it changes. In other words, in the current code, we already could run the task below immediately, in which case we would see the request_pending_==true and skip, right? -- To view, visit http://gerrit.cloudera.org:8080/9092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62ec4ea91e976590ce2de4fa34db61eaf9aab92a Gerrit-Change-Number: 9092 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 23 Jan 2018 21:40:17 +0000 Gerrit-HasComments: Yes
