Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 )
Change subject: KUDU-2262: allow Java client to retry if no master is a leader ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@10 PS1, Line 10: cause > nit: causes Done http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: irst lead > nit: election Done http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: r > nit: even if Done http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: h > nit: drop Done http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: are > nit: are Done http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@11 PS1, Line 11: very > I think that can happen only during the very first leader election after ma Right. updated. http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@12 PS1, Line 12: he cli > nit: token Done http://gerrit.cloudera.org:8080/#/c/9088/1//COMMIT_MSG@16 PS1, Line 16: has valid secondary authn credentials (such as authn token), but it : does not have primary authn credentials (such as Kerberos creds), and : retry the request as long as t > Could you update this piece to reflect the actual logic of the code (as in Done -- To view, visit http://gerrit.cloudera.org:8080/9088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia39a8d77cbf58c6f2f1f97eaf5e2e17ac1fa09fa Gerrit-Change-Number: 9088 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2018 20:52:47 +0000 Gerrit-HasComments: Yes
