Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9132
to review the following change.
Change subject: client: fix UBSAN error in failover calculation
......................................................................
client: fix UBSAN error in failover calculation
A misplaced typecast caused the following:
/data/somelongdirectorytoavoidrpathissues/src/kudu/src/kudu/client/scanner-internal.cc:433:72:
runtime error: unsigned integer overflow: 4 - 5 cannot be represented in type
'unsigned long'
This patch simply rearranges the expression a bit to avoid underflow
possibilities.
Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
---
M src/kudu/client/scanner-internal.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/9132/1
--
To view, visit http://gerrit.cloudera.org:8080/9132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd137f86443bc4af59f8a4290a45151afda6c090
Gerrit-Change-Number: 9132
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
