Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9159 )
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9159/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/9159/1/CMakeLists.txt@1093 PS1, Line 1093: execute_process( is this now redundant with the above compiler version checks? ie if this succeeds, then why do we care what version it is? http://gerrit.cloudera.org:8080/#/c/9159/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/9159/1/thirdparty/download-thirdparty.sh@134 PS1, Line 134: patch -p1 < $TP_DIR/patches/gperftools-sized-alloc-build-fix.patch did you file a bug upstream with gperftools for this? -- To view, visit http://gerrit.cloudera.org:8080/9159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840 Gerrit-Change-Number: 9159 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2018 01:37:40 +0000 Gerrit-HasComments: Yes
