David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9161 )
Change subject: Don't rely on pending config OpId index for peer promotion ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9161/3/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/9161/3/src/kudu/consensus/consensus_queue.cc@a982 PS3, Line 982: > I'm not 100% following the commit message and how it corresponds to this an true, but what I guess I was saying is. do we care? there are at least a couple of cases where it might be interesting to not pass a committed config index: 1 - If the config is committed by the time the notification is executed, but is not yet here 2 - if the config changed since between we check it here and in consensus, but the peer is still up for promotion. in the worst case we issue some extra notifications. that being said I can easily add the check for "pendingness". That would eliminate possibility 1. actually passing the committed index I don't think would buy us anything though. -- To view, visit http://gerrit.cloudera.org:8080/9161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a033ce16f626458efdb59b1b4dd8450e8591761 Gerrit-Change-Number: 9161 Gerrit-PatchSet: 3 Gerrit-Owner: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 02:42:28 +0000 Gerrit-HasComments: Yes
