Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9161 )
Change subject: Don't rely on pending config OpId index for peer promotion ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9161/3/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/9161/3/src/kudu/consensus/consensus_queue.cc@a982 PS3, Line 982: I'm not 100% following the commit message and how it corresponds to this and the above removed comment. Wouldn't it be sufficient to just pass the _committed_ config's opid index here instead of the active config? I see we don't have access to the committed config in the context of the queue state, but it seems like it would also be reasonable to say that, if the active_config has no opid_index (i.e. it is a pending config) then we know that the attempt to promote is going to fail anyway. In that case we can just skip the notification. -- To view, visit http://gerrit.cloudera.org:8080/9161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a033ce16f626458efdb59b1b4dd8450e8591761 Gerrit-Change-Number: 9161 Gerrit-PatchSet: 3 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2018 01:19:16 +0000 Gerrit-HasComments: Yes
