Hello Will Berkeley, Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9172
to review the following change.
Change subject: maintenance_manager: log the reason for scheduling each
operation
......................................................................
maintenance_manager: log the reason for scheduling each operation
This makes it easier to troubleshoot when the maintenance manager
appears to be scheduling the "wrong" operation.
Example output from a long run of full_stack_insert_scan-test:
I0131 15:00:21.154744 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
FlushMRSOp(eaa9b5237a14425e852ca97c2b4ae138): under memory pressure (60.52%
used), running op which anchors most memory (642916119 bytes)
I0131 15:00:24.241927 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
LogGCOp(eaa9b5237a14425e852ca97c2b4ae138): can GC 394382000 bytes of logs with
low IO cost
I0131 15:00:24.309976 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
UndoDeltaBlockGCOp(eaa9b5237a14425e852ca97c2b4ae138): can free up the most data
on disk (29912621 bytes)
I0131 15:00:24.310154 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
CompactRowSetsOp(eaa9b5237a14425e852ca97c2b4ae138): best performance
improvement (score=0.281733)
I0131 15:00:26.482787 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
CompactRowSetsOp(eaa9b5237a14425e852ca97c2b4ae138): best performance
improvement (score=0.281354)
I0131 15:00:28.514597 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
UndoDeltaBlockGCOp(eaa9b5237a14425e852ca97c2b4ae138): can free up the most data
on disk (36234163 bytes)
I0131 15:00:28.514787 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
CompactRowSetsOp(eaa9b5237a14425e852ca97c2b4ae138): best performance
improvement (score=0.204581)
I0131 15:00:30.165297 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
CompactRowSetsOp(eaa9b5237a14425e852ca97c2b4ae138): best performance
improvement (score=0.150718)
I0131 15:00:31.783936 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
CompactRowSetsOp(eaa9b5237a14425e852ca97c2b4ae138): best performance
improvement (score=0.024950)
I0131 15:00:32.740442 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
UndoDeltaBlockGCOp(eaa9b5237a14425e852ca97c2b4ae138): can free up the most data
on disk (38786747 bytes)
I0131 15:00:36.495453 13887 maintenance_manager.cc:300] P
e96b0ba97e104a4294feef1163f7383f: Scheduling
FlushMRSOp(eaa9b5237a14425e852ca97c2b4ae138): under memory pressure (60.45%
used), running op which anchors most memory (637714199 bytes)
Change-Id: I4dcdb863a7a0b0fc2a72757801d5c057fa725c34
---
M src/kudu/util/debug/trace_logging.h
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
4 files changed, 74 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/9172/1
--
To view, visit http://gerrit.cloudera.org:8080/9172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4dcdb863a7a0b0fc2a72757801d5c057fa725c34
Gerrit-Change-Number: 9172
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
