Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9181 to look at the new patch set (#2). Change subject: jsonwriter: do some internal buffering in front of ostringstream ...................................................................... jsonwriter: do some internal buffering in front of ostringstream JsonWriter outputs into a std::ostringstream, and the RapidJSON interface is such that we always append one character at a time. ostringstream::put(char) is not inlined, so this is very slow. This patch adds a small buffer in front of the ostringstream. We flush the buffer on the end of any JSON array or object. The patch adds a simple benchmark to show the improvement: Before: I0131 20:26:09.437477 16201 jsonwriter-test.cc:187] Throughput: 87.0644MB/sec After: I0131 20:24:17.889117 15929 jsonwriter-test.cc:187] Throughput: 154.192MB/sec The remaining perf issues seem to be due to our use of protobuf reflection. Change-Id: Ib45d58187cf80ecfe2f5a25e40d7042e4a27619d --- M src/kudu/util/jsonwriter-test.cc M src/kudu/util/jsonwriter.cc 2 files changed, 77 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/9181/2 -- To view, visit http://gerrit.cloudera.org:8080/9181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib45d58187cf80ecfe2f5a25e40d7042e4a27619d Gerrit-Change-Number: 9181 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>