Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9236 )
Change subject: [docs] MacPorts specific build instructions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) I didn't test it but it looks right. One small worry I have about the patch is that it mostly duplicates the build-Kudu-on-macOS script, so two copies need to be maintained. I think this is OK since the script shouldn't change very much and the two copies are right next to each other. http://gerrit.cloudera.org:8080/#/c/9236/1/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/9236/1/docs/installation.adoc@545 PS1, Line 545: $ brew tap homebrew/dupes While you're here, I think this is outdated: $ brew tap homebrew/dupes Error: homebrew/dupes was deprecated. This tap is now empty as all its formulae were migrated. -- To view, visit http://gerrit.cloudera.org:8080/9236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic103c1d883cd94c5e21b291e81005e14324a813f Gerrit-Change-Number: 9236 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 07 Feb 2018 16:55:17 +0000 Gerrit-HasComments: Yes
