Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9237

to review the following change.


Change subject: Add previous / current thread to collision warner
......................................................................

Add previous / current thread to collision warner

The failure message is now more useful and looks like the following:

F0206 20:31:24.554322 30972 thread_collision_warner.cc:23] Thread Collision! 
Previous thread id: 30962, current thread id: 30972

I found this necessary when debugging a particular issue since by the
time the SIGABRT triggered in GDB the previous thread had already exited
the critical section (perhaps while printing the fatal log message).

Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7
---
M src/kudu/gutil/threading/thread_collision_warner.cc
M src/kudu/gutil/threading/thread_collision_warner.h
2 files changed, 15 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9237/1
--
To view, visit http://gerrit.cloudera.org:8080/9237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7
Gerrit-Change-Number: 9237
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to