Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9257 )
Change subject: Fix client comaptibility with gcc 4.4 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9257/2/src/kudu/common/key_encoder.cc File src/kudu/common/key_encoder.cc: http://gerrit.cloudera.org:8080/#/c/9257/2/src/kudu/common/key_encoder.cc@58 PS2, Line 58: #ifdef KUDU_INT128_SUPPORTED > for these changes in .cc files is this required? We only build the client l Done http://gerrit.cloudera.org:8080/#/c/9257/2/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/9257/2/src/kudu/common/types.h@327 PS2, Line 327: #ifdef KUDU_INT128_SUPPORTED > This header isn't part of the client library so I don't think it should be Done -- To view, visit http://gerrit.cloudera.org:8080/9257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59b40a9718b321df1a5878160ac845d4cf3d9170 Gerrit-Change-Number: 9257 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 02:38:53 +0000 Gerrit-HasComments: Yes
