Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9257 )
Change subject: Fix client comaptibility with gcc 4.4 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9257/4/src/kudu/util/int128.h File src/kudu/util/int128.h: http://gerrit.cloudera.org:8080/#/c/9257/4/src/kudu/util/int128.h@24 PS4, Line 24: defined(__clang__) || \ : (defined(__GNUC__) && \ : (__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40600) this probably needs parens around the whole thing or else it would cause problems in an expression like: #if KUDU_INT128_SUPPORTED && BLAH_BLAH (due to operator precedence the && would apply only to the second half of the conjunction) Alternatively change to: #if ... #define KUDU_INT128_SUPPORTED 1 #else #define KUDU_INT128_SUPPORTED 0 #endif -- To view, visit http://gerrit.cloudera.org:8080/9257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59b40a9718b321df1a5878160ac845d4cf3d9170 Gerrit-Change-Number: 9257 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 19:40:42 +0000 Gerrit-HasComments: Yes
