Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9252 )
Change subject: KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization ...................................................................... KUDU-2291 (part 1): allow collecting a thread's stack without immediate symbolization For the /stacks page we would like to be able to grab the stack from a bunch of threads as quickly as possible to eliminate "skid" between the collection times. Symbolization of stacks is much slower than collection, so this patch adds a new API to collect the remote thread stack without symbolizing it immediately. This adds a simple benchmark for remote thread stack collection. The initial results are not that different between symbolized and unsymbolized because the stack collection performance itself is poor. This will be improved in a later patch in this series. I0207 19:33:20.960477 30799 debug-util-test.cc:175] Throughput: 99 dumps/second (symbolize=0) I0207 19:33:21.963946 30799 debug-util-test.cc:175] Throughput: 84 dumps/second (symbolize=1) Change-Id: I0a14fbb7d0cafcd7b966dac507e71bae32e2cc1a Reviewed-on: http://gerrit.cloudera.org:8080/9252 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley <[email protected]> --- M src/kudu/util/debug-util-test.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h 3 files changed, 52 insertions(+), 9 deletions(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0a14fbb7d0cafcd7b966dac507e71bae32e2cc1a Gerrit-Change-Number: 9252 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
