David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/8804/14/src/kudu/tserver/tablet_service.h File src/kudu/tserver/tablet_service.h: http://gerrit.cloudera.org:8080/#/c/8804/14/src/kudu/tserver/tablet_service.h@156 PS14, Line 156: // as such timestamp is invalid. nit: "such a" http://gerrit.cloudera.org:8080/#/c/8804/14/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/8804/14/src/kudu/tserver/tablet_service.cc@2046 PS14, Line 2046: return Status::NotSupported("Unsupported snapshot scan mode specified"); nit: I think this can FATAL out. it's us (not the user) that call this and we should only call it for "snapshotty" scans http://gerrit.cloudera.org:8080/#/c/8804/14/src/kudu/tserver/tablet_service.cc@2166 PS14, Line 2166: RETURN_NOT_OK(ValidateTimeStamp(tmp_snap_timestamp)); What is this really checking. We need to validate the timestamp for READ_AT_SNAPSHOT as the user can send a timestamp that is arbitrarily in the future, but here it can only be either "clean_timestamp" (which is valid) or propagated timestamp, which is necessarily valid since we've udpated the clock with it in line 2139. In other words do you think that there is a test case you can write that would fail this check? -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 14 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 16 Feb 2018 20:08:57 +0000 Gerrit-HasComments: Yes
