David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/8804/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8804/12//COMMIT_MSG@15 PS12, Line 15: choose the newest timestamp : within the staleness bound that allows execution of the reads without : being blocked by the in-flight transactions might be worth adding "if possible" http://gerrit.cloudera.org:8080/#/c/8804/12/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8804/12/src/kudu/tserver/tablet_server-test.cc@1924 PS12, Line 1924: TestScanYourWrites It worries me a bit that most tests of this functionality overwhelmingly tests the "happy" case. A good test of that is: if you changed the mode of all tests here to READ_LATEST would it fail? if not that's ok as long as we have some test somewhere that would, however I didn't see such a tests even after the client implementations. Jepsen tests are good to cover more possibilities, but some deterministic tests just for RYW should exist. -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 09 Feb 2018 20:09:16 +0000 Gerrit-HasComments: Yes
