Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/8823/8/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/8823/8/src/kudu/client/client-internal.h@197 PS8, Line 197: // Returns the max observed timestamp from servers that only for all > Please add docs to these, since it's not obvious anymore, e.g. what's the d Done http://gerrit.cloudera.org:8080/#/c/8823/8/src/kudu/client/client-internal.h@278 PS8, Line 278: > As implemented here, isn't there interactions between two concurrently opened > RYW scanners? Right, I think the idea of using a client property is to track the current/max observed timestamp across all opened RYW scanners. Whenever there is a new scanner open, always use the max of all to ensure read-your-reads. I am not sure how can we achieve this if we use a scanner property/field. http://gerrit.cloudera.org:8080/#/c/8823/8/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/8823/8/src/kudu/client/client.h@1740 PS8, Line 1740: /// When @c READ_YOUR_WRITES is specified, the server will pick a timestamp to use > We should consider 'dumbing down' these docs considerably. For instance, t Good point, will add her as a reviewer. -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 9 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 17 Feb 2018 00:31:29 +0000 Gerrit-HasComments: Yes
