Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/8823/8/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/8823/8/src/kudu/client/client-internal.h@278 PS8, Line 278: AtomicInt<uint64_t> max_observed_timestamp_; > > As implemented here, isn't there interactions between two concurrently op IIUC the RYW scan mode picks a propagated timestamp up-front, and then propagates that same timestamp with every NewScanRequest RPC. To me, that implies that the timestamp should be kept in a field of the scanner, since it's a value specific to that scanner. Instead it looks like it's being kept as a field on the client, and therefore is shared among potentially many scanners. Isn't that problematic? Edit: wrote the above, then read David's bullet-pointed comment. I think he and I are basically getting to the same point. -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 20:47:44 +0000 Gerrit-HasComments: Yes
