Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9363 )
Change subject: KUDU-721: Support range partitions on decimal columns ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc@1639 PS1, Line 1639: u_schema_ nit: I don't think we use identifiers like 'x_' for local variables; would 'u_schema' suffice here? http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc@1643 PS1, Line 1643: CHECK_OK why not just ASSERT_OK() ? http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc@1645 PS1, Line 1645: unique_ptr<KuduPartialRow> lower_bound(u_schema_.NewRow()); : ASSERT_OK(lower_bound->SetUnscaledDecimal("key", -1)); : unique_ptr<KuduPartialRow> upper_bound(u_schema_.NewRow()); : ASSERT_OK(upper_bound->SetUnscaledDecimal("key", 99)); I think it would be nice to add a 'negative' test case (maybe, in some different scenario) to test for: * swapped upper/lower bounds (e.g., upper -1, lower 99) * bounds that lead to an empty partition (e.g. lower 10, upper 10) * bounds with MAX and MIN values http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/common/partition.cc@1043 PS1, Line 1043: ColumnSchema const reference? -- To view, visit http://gerrit.cloudera.org:8080/9363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I419d442dd233c73166c6e391907c8443ebecc917 Gerrit-Change-Number: 9363 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 20 Feb 2018 22:59:18 +0000 Gerrit-HasComments: Yes
