Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9363 )
Change subject: KUDU-721: Support range partitions on decimal columns ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc@1639 PS1, Line 1639: schema; > nit: I don't think we use identifiers like 'x_' for local variables; would Ah, right. I copied this test from the UnixTimeMicros one above. Will update both. http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc@1643 PS1, Line 1643: ASSERT_O > why not just ASSERT_OK() ? Done http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/client/client-test.cc@1645 PS1, Line 1645: unique_ptr<KuduPartialRow> lower_bound(schema.NewRow()); : ASSERT_OK(lower_bound->SetUnscaledDecimal("key", -1)); : unique_ptr<KuduPartialRow> upper_bound(schema.NewRow()); : ASSERT_OK(upper_bound->SetUnscaledDecimal("key", 99)); > I think it would be nice to add a 'negative' test case (maybe, in some diff Done http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/9363/1/src/kudu/common/partition.cc@1043 PS1, Line 1043: const ColumnS > const reference? Done -- To view, visit http://gerrit.cloudera.org:8080/9363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I419d442dd233c73166c6e391907c8443ebecc917 Gerrit-Change-Number: 9363 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 21 Feb 2018 05:01:38 +0000 Gerrit-HasComments: Yes
