Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9137 )
Change subject: internal_mini_cluster: support Cluster/LogVerifier ...................................................................... internal_mini_cluster: support Cluster/LogVerifier This patch introduces a MiniCluster-agnostic MiniClusterFsInspector. With this, the LogVerifier, and thus, the ClusterVerifier can support both External- and InternalMiniClusters. The LogVerifier would originally open a read-only FsManager (which in turn would open a BlockManager and a DataDirManager) per server and pass it to the LogReader to inspect the WALs. Instead, the LogVerifier now creates a MiniClusterFsInspector, which is more lightweight and defined per cluster. To the LogReader, it passes the WAL directory and an env, which is all the LogReader needed from the FsManager in the first place. To test, I updated a test case in ts_tablet_manager-itest to make use of the new ClusterVerifier with an internal cluster. CheckCluster() uses a LogVerifier, which in this case uses an MiniClusterFsInspector that operates on an InternalMiniCluster. Change-Id: I228a6e3ba1a42db4e243ffdc5116f0c60ee04a84 Reviewed-on: http://gerrit.cloudera.org:8080/9137 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <mpe...@apache.org> --- M src/kudu/consensus/log-test.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_reader.h M src/kudu/fs/fs_manager.h M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/client_failover-itest.cc M src/kudu/integration-tests/cluster_verifier.cc M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/external_mini_cluster-itest-base.cc M src/kudu/integration-tests/external_mini_cluster-itest-base.h M src/kudu/integration-tests/log_verifier.cc M src/kudu/integration-tests/log_verifier.h R src/kudu/integration-tests/mini_cluster_fs_inspector.cc R src/kudu/integration-tests/mini_cluster_fs_inspector.h M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tablet_copy_client_session-itest.cc M src/kudu/integration-tests/tablet_replacement-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/integration-tests/tombstoned_voting-stress-test.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/integration-tests/ts_itest-base.h M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/mini-cluster/internal_mini_cluster.cc M src/kudu/mini-cluster/internal_mini_cluster.h M src/kudu/mini-cluster/mini_cluster.h M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/kudu-ts-cli-test.cc 37 files changed, 313 insertions(+), 305 deletions(-) Approvals: Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I228a6e3ba1a42db4e243ffdc5116f0c60ee04a84 Gerrit-Change-Number: 9137 Gerrit-PatchSet: 13 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
