Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9137 )
Change subject: internal_mini_cluster: support Cluster/LogVerifier ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/9137/9/src/kudu/integration-tests/external_mini_cluster_fs_inspector.h File src/kudu/integration-tests/external_mini_cluster_fs_inspector.h: http://gerrit.cloudera.org:8080/#/c/9137/9/src/kudu/integration-tests/external_mini_cluster_fs_inspector.h@30 PS9, Line 30: > hrm, I might be missing something here, but what if you just added the appr Wasn't a huge fan of including these methods in the minicluster itself since they're not useful other than for FS inspecting at the moment, but I agree it makes this change cleaner. Done -- To view, visit http://gerrit.cloudera.org:8080/9137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228a6e3ba1a42db4e243ffdc5116f0c60ee04a84 Gerrit-Change-Number: 9137 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 05 Feb 2018 07:05:53 +0000 Gerrit-HasComments: Yes
