Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9262 )
Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection ...................................................................... Patch Set 5: (2 comments) Nice. How the heck did you even stumble upon this workaround? http://gerrit.cloudera.org:8080/#/c/9262/5/src/kudu/util/debug/unwind_safeness.cc File src/kudu/util/debug/unwind_safeness.cc: http://gerrit.cloudera.org:8080/#/c/9262/5/src/kudu/util/debug/unwind_safeness.cc@53 PS5, Line 53: libdl nit: period at end http://gerrit.cloudera.org:8080/#/c/9262/5/src/kudu/util/debug/unwind_safeness.cc@63 PS5, Line 63: * nit: any reason to move the asterisks around from their usual place in these signatures? -- To view, visit http://gerrit.cloudera.org:8080/9262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I414718a26c4810de86a10397bb9803dc5e386d1a Gerrit-Change-Number: 9262 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 21 Feb 2018 01:12:49 +0000 Gerrit-HasComments: Yes
