Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9262 )
Change subject: KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection ...................................................................... KUDU-2291 (part 4): avoid potential for deadlocks in stack trace collection This follows some recommendations from [1] to avoid the potential for deadlocks if we attempt to gather a stack trace from a signal handler context while the thread is inside calls to libdl. The approach is somewhat ugly: we have to override the sensitive libdl calls and use them to increment a thread-local counter indicating that it would be unsafe to collect a stack. We then check this counter before capturing a stack: if we see that we are inside libdl we just return an fake stack trace indicating why it could not be captured. The new test included deadlocks reliably without the fix. [1] https://github.com/gperftools/gperftools/wiki/gperftools'-stacktrace-capturing-methods-and-their-issues Change-Id: I414718a26c4810de86a10397bb9803dc5e386d1a Reviewed-on: http://gerrit.cloudera.org:8080/9262 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/util/CMakeLists.txt M src/kudu/util/debug-util-test.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h A src/kudu/util/debug/unwind_safeness.cc A src/kudu/util/debug/unwind_safeness.h 6 files changed, 291 insertions(+), 10 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I414718a26c4810de86a10397bb9803dc5e386d1a Gerrit-Change-Number: 9262 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
