Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9387 )
Change subject: [consensus_peers] micro-optimization on controller status ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9387/2//COMMIT_MSG@13 PS2, Line 13: 1.13% kudu-tserver libtcmalloc.so.4.5.1 [.] operator new[](unsigned long) : - operator new[](unsigned long) : ... : + 3.21% kudu::Status::CopyState(char const*) : kudu::Status::Status(kudu::Status const&) : kudu::rpc::OutboundCall::status() const : kudu::rpc::RpcController::status() const : kudu::consensus::Peer::ProcessResponse() : ... Are these from `perf`? -- To view, visit http://gerrit.cloudera.org:8080/9387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25ac21db191a21f3bdfb3378e32fbe366d98297c Gerrit-Change-Number: 9387 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 04:33:45 +0000 Gerrit-HasComments: Yes