Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9387 )
Change subject: [consensus_peers] micro-optimization on controller status ...................................................................... [consensus_peers] micro-optimization on controller status While running raft_consensus_stress-itest where a lot of RPC fail, I found the following stats for operator new[](unsigned long) in tserver with regard of Status::CopyState(): - 1.13% kudu-tserver libtcmalloc.so.4.5.1 [.] operator new[](unsigned long) - operator new[](unsigned long) ... + 3.21% kudu::Status::CopyState(char const*) kudu::Status::Status(kudu::Status const&) kudu::rpc::OutboundCall::status() const kudu::rpc::RpcController::status() const kudu::consensus::Peer::ProcessResponse() ... Of course, that's not in the hot path in case of success scenarios, but I think it makes sense to add these micro-optimizations. Change-Id: I25ac21db191a21f3bdfb3378e32fbe366d98297c Reviewed-on: http://gerrit.cloudera.org:8080/9387 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <aw...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/consensus/consensus_peers.cc 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, but someone else must approve Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I25ac21db191a21f3bdfb3378e32fbe366d98297c Gerrit-Change-Number: 9387 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>