Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9327 )
Change subject: KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog ...................................................................... KUDU-2297 (part 2). Convert diagnostics log to a format closer to glog Previously the metrics/diagnostics log used a custom log format designed to be readable by scripts. The only timestamps were unix microtimes, which are convenient for computers but not for people. In order to make the log more easily greppable, this patch converts it over to use a glog-compatible prefix on each log line. The aim is that, if an admin sees some issues at 10/23 15:03 they can simply grep the diagnostics log for '1021 15:0[0-6]' rather than having to go figure out the appropriate range of numeric timestamps. This patch also updates the docs accordingly. Change-Id: I10d93c84f8c738c26850ae3d1ae6afbb5519c7ad Reviewed-on: http://gerrit.cloudera.org:8080/9327 Tested-by: Todd Lipcon <[email protected]> Reviewed-by: Mike Percy <[email protected]> --- M docs/administration.adoc M src/kudu/server/diagnostics_log.cc M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/trace.cc 5 files changed, 46 insertions(+), 29 deletions(-) Approvals: Todd Lipcon: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I10d93c84f8c738c26850ae3d1ae6afbb5519c7ad Gerrit-Change-Number: 9327 Gerrit-PatchSet: 9 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
