Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9440 )
Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc File src/kudu/common/generic_iterators-test.cc: http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc@347 PS1, Line 347: : schema_(std::move(schema)) { > warning: passing result of std::move() as a const reference argument; no mo Not sure what this means. maybe Schema doesn't have a move ctor? I don't want to take that on in this patch. http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc@350 PS1, Line 350: Status Init(ScanSpec *spec) override { > warning: parameter 'spec' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc@354 PS1, Line 354: virtual Status NextBlock(RowBlock* dst) override { > warning: parameter 'dst' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/9440/1/src/kudu/common/generic_iterators-test.cc@402 PS1, Line 402: CHECK > ASSERT_TRUE? That requires the types to be printable, unfortunately. -- To view, visit http://gerrit.cloudera.org:8080/9440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348 Gerrit-Change-Number: 9440 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 24 Feb 2018 01:37:52 +0000 Gerrit-HasComments: Yes
