Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py File build-support/gen_version_info.py: http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py@23 PS2, Line 23: import hashlib > Does it work for python 2.7? Some time ago I looked at that as well: https://gerrit.cloudera.org/#/c/8353 It seemed to me that it was necessary to do something like the following to make it work for python 2.6/2.7: try: from hashlib import sha1 except: from sha import sha as sha1 -- To view, visit http://gerrit.cloudera.org:8080/9492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57 Gerrit-Change-Number: 9492 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 05 Mar 2018 18:39:40 +0000 Gerrit-HasComments: Yes
