Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py File build-support/gen_version_info.py: http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py@23 PS2, Line 23: import hashlib > Some time ago I looked at that as well: Yeah, it appears to work on my system's 2.6 and 2.7. http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py File build-support/push_to_asf.py: http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py@83 PS2, Line 83: except subprocess.CalledProcessError: : print >>sys.stderr, "No remote named 'gerrit'. Please set one up following " : print >>sys.stderr, "the contributor guide." : sys.exit(1) : if not GERRIT_URL_RE.match(url): : print >>sys.stderr, "Unexpected URL for remote 'gerrit'." : print >>sys.stderr, " Got: ", url : print >>sys.stderr, " Expected to find host '%s' in the URL" % GERRIT_HOST > Does this work in python3? nope, good catch. -- To view, visit http://gerrit.cloudera.org:8080/9492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57 Gerrit-Change-Number: 9492 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 05 Mar 2018 19:28:46 +0000 Gerrit-HasComments: Yes
