Hello Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9499
to review the following change.
Change subject: decimal_util: do not produce warnings when building with gcc
......................................................................
decimal_util: do not produce warnings when building with gcc
When I build with gcc5, I get the following warning:
../../src/kudu/util/decimal_util.cc:31:45: warning: ‘no_sanitize’ attribute
directive ignored [-Wattributes]
int128_t MaxUnscaledDecimal(int8_t precision) {
This is because gcc doesn't recognize the "no_sanitize" attribute, so let's
deal with this as we've dealt with other sanitizer suppressions: compile it
conditionally using ASAN support as a proxy.
Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd
---
M src/kudu/gutil/port.h
M src/kudu/util/decimal_util.cc
2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9499/1
--
To view, visit http://gerrit.cloudera.org:8080/9499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd
Gerrit-Change-Number: 9499
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
