Adar Dembo has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/9499 )
Change subject: decimal_util: do not produce warnings when building with gcc
......................................................................
decimal_util: do not produce warnings when building with gcc
When I build with gcc5, I get the following warning:
../../src/kudu/util/decimal_util.cc:31:45: warning: ‘no_sanitize’ attribute
directive ignored [-Wattributes]
int128_t MaxUnscaledDecimal(int8_t precision) {
This is because gcc doesn't recognize the "no_sanitize" attribute, so let's
deal with this as we've dealt with other sanitizer suppressions: compile it
conditionally using ASAN support as a proxy.
Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd
Reviewed-on: http://gerrit.cloudera.org:8080/9499
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <granthe...@gmail.com>
---
M src/kudu/gutil/port.h
M src/kudu/util/decimal_util.cc
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac9b145a914d551e3a18d62a0984aad34b95f4dd
Gerrit-Change-Number: 9499
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
