David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8847 )
Change subject: KUDU-1704: add java client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8847/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8847/7//COMMIT_MSG@6 PS7, Line 6: : KUDU-1704: add java client support for READ_YOUR_WRITES mode > Unfortunately, did not get a change to spend much time on it yet, but shoul ok, thats fine. really want to make sure we don't drop it though, if we're willing to go the distance in implementing RYW we should also test it properly. super weird corner cases often pop up and jepsen is one of the best tools to let you know that went wrong and why. http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@418 PS7, Line 418: if (readMode == ReadMode.READ_YOUR_WRITES && : resp.scanTimestamp != AsyncKuduClient.NO_TIMESTAMP) { : client.updateLastPropagatedTimestamp(resp.scanTimestamp); : } else if (resp.propagatedTimestamp != AsyncKuduClient.NO_TIMESTAMP) { : client.updateLastPropagatedTimestamp(resp.propagatedTimestamp); : } > I guess you are saying the comment above is not clear enough. Will update. yeah, that's why I said slightly simplified. I agree that we might want to keep the flow for consistency. the point about the comment was more important though -- To view, visit http://gerrit.cloudera.org:8080/8847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6239521c022147257859e399f55c6f3f945af465 Gerrit-Change-Number: 8847 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 06 Mar 2018 00:13:19 +0000 Gerrit-HasComments: Yes
