Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8847 )
Change subject: KUDU-1704: add java client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/8847/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8847/7//COMMIT_MSG@6 PS7, Line 6: : KUDU-1704: add java client support for READ_YOUR_WRITES mode > ok, thats fine. really want to make sure we don't drop it though, if we're Yeah, totally makes sense to me. I will certainly pick up the jepsen test with RYW. http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@817 PS7, Line 817: case OPENING: > nit, comma after "set" Done http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@818 PS7, Line 818: nner. This kind of a > pet peeve: propagated timestamp or propagation timestamp? are these differe Done http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1044 PS7, Line 1044: run > nit: "are running" or just "run" Done http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1047 PS7, Line 1047: // scan mode, from leader replica. In this test writes are > nit: comma after "scan mode" Done http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1062 PS7, Line 1062: // Similar to testReadYourWritesSyncLeaderReplica, but in this : // test writes are performed in MANUAL_FLUSH (batches) flush modes. : @Test(timeout = 100000) : public void testReadYourWritesBa > This text is repeated. Likely add it to the first test and then make the ot Done http://gerrit.cloudera.org:8080/#/c/8847/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1086 PS7, Line 1086: > avoid magic numbers (set a final var) Done -- To view, visit http://gerrit.cloudera.org:8080/8847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6239521c022147257859e399f55c6f3f945af465 Gerrit-Change-Number: 8847 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 06 Mar 2018 00:35:23 +0000 Gerrit-HasComments: Yes
