Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9524 )
Change subject: build: don't name unsharded tests with a shard suffix ...................................................................... Patch Set 1: (1 comment) No need to purge the flaky test DB since we track flakiness on a per-suite level rather than per-shard currently (see http://dist-test.cloudera.org:8080/) http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh@68 PS1, Line 68: :-0 > Under what circumstances would we have more than one shard but GTEST_SHARD_ yea probably. It seems gtest will fail if you try it: todd@todd-laptop:/src/kudu$ GTEST_TOTAL_SHARDS=1 ./build/latest/bin/rpc-test Invalid environment variables: you have GTEST_TOTAL_SHARDS = 1, but have left GTEST_SHARD_INDEX unset. -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 07 Mar 2018 19:26:46 +0000 Gerrit-HasComments: Yes
