Todd Lipcon has posted comments on this change. ( )

Change subject: KUDU-2264. java: automatically attempt to re-acquire Kerberos 

Patch Set 3:

Commit Message:
PS3, Line 7: java: automatically attempt to re-acquire Kerberos credentials 
before expiration
> nit: this looks too long; maybe
File java/kudu-client/src/main/java/org/apache/kudu/client/
PS3, Line 113: associate them with a {@link}
             :  * instance, and associate them with the current thread of 
> it will be a bit wordier, but I think you should avoid pronouns (them) in t
PS3, Line 143:  * example by re-running 'kinit' once each key.
> Probably a typo: "by re-running 'kinit' once each key" should probably read
PS3, Line 180: This
> Specify that this is a function of UserGroupInformation
PS3, Line 185:  The Kudu client emits
             :  * DEB
> wrapping
PS3, Line 221: {@link InterfaceAudience.Private
> Are we giving up on ever changing an Unstable interface?  Might be good to
File java/kudu-client/src/main/java/org/apache/kudu/util/
PS3, Line 97:         options.put("debug", 
> Is this trick worth adding to the debug section of your new doc?
PS3, Line 170:       return millisUntilEnd * 1000 < 
> Shouldn't this be multiplying the expiration_secs by 1000 to make the units
good catch, put the multiplication on the wrong side!

To view, visit
To unsubscribe, visit

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I514253e0a7f067dbc8ffe4eaf5a7a2c32900b539
Gerrit-Change-Number: 9050
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Alexey Serbin <>
Gerrit-Reviewer: Anonymous Coward #380
Gerrit-Reviewer: Dan Burkert <>
Gerrit-Reviewer: Hao Hao <>
Gerrit-Reviewer: Jean-Daniel Cryans <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-Comment-Date: Wed, 07 Mar 2018 20:51:33 +0000
Gerrit-HasComments: Yes

Reply via email to