Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9432 )
Change subject: [doc] Document the new decimal column type ...................................................................... Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/9432/2/docs/developing.adoc File docs/developing.adoc: http://gerrit.cloudera.org:8080/#/c/9432/2/docs/developing.adoc@183 PS2, Line 183: , > nit: remove this comma (even if you are a fan of the oxford comma, you only Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/known_issues.adoc File docs/known_issues.adoc: http://gerrit.cloudera.org:8080/#/c/9432/2/docs/known_issues.adoc@56 PS2, Line 56: * Type and nullability of existing columns cannot be changed by altering the table. > maybe worth adding a note here that the precision and scale of DECIMAL colu Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/9432/2/docs/release_notes.adoc@53 PS2, Line 53: * Kudu now supports a decimal column type. The decimal type is a numeric data type > it's probably worth some note in compat section on what happens if you try Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/release_notes.adoc@53 PS2, Line 53: a > the Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc File docs/schema_design.adoc: http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc@99 PS2, Line 99: float > should we format 'float' and 'double' with `...` so it shows up more like a Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc@100 PS2, Line 100: int64 > same Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc@103 PS2, Line 103: a precision and scale > "a" seems misplaced Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc@108 PS2, Line 108: For example, representing : integer values up to 9999, and fractional values up to 99.99, both require a : precision of 4 > I think this would read a little more clearly written as: Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc@116 PS2, Line 116: If precision and scale are equal, all the digits come after the decimal point, : making all the values between -0.999... and 0.999... > This sentence is a bit confusing. Perhaps: Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc@129 PS2, Line 129: * Decimal values with precision greater than 18 are stored in 16 bytes. > Is it worth adding a note that we don't currently support BITSHUFFLE encodi Done http://gerrit.cloudera.org:8080/#/c/9432/2/docs/schema_design.adoc@143 PS2, Line 143: bitshuffle > is bitshuffle the default for int128? I thought it wasnt supported but mayb I think you are thinking of run length. That is tracked by KUDU-2284. -- To view, visit http://gerrit.cloudera.org:8080/9432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9489613d35daad708648ea04d49e472d3149b33d Gerrit-Change-Number: 9432 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 07 Mar 2018 23:33:53 +0000 Gerrit-HasComments: Yes
