Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9595
to review the following change.
Change subject: Remove tcmalloc_spinlock_contention metric
......................................................................
Remove tcmalloc_spinlock_contention metric
Spinlock contention was removed from tcmalloc upstream, so this metric
has been set to 0 since we upgraded to tcmalloc 2.6. I looked briefly at
reverting its removal upstream, but the revert would be fairly large, so
I think it's best to just accept the loss of this instrumentation.
Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
---
M docs/release_notes.adoc
M src/kudu/scripts/parse_metrics_log.py
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
M src/kudu/util/spinlock_profiling.h
M src/kudu/util/trace.h
M src/kudu/util/trace_metrics.h
7 files changed, 7 insertions(+), 103 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/9595/1
--
To view, visit http://gerrit.cloudera.org:8080/9595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324
Gerrit-Change-Number: 9595
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
