Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9596 )
Change subject: KUDU-2153. Servers should not delete tmp files until after locking directories ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9596/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9596/1//COMMIT_MSG@31 PS1, Line 31: unused Looks like it became unused in https://github.com/apache/kudu/commit/61a227735032974ea0c5c3045be7f092a41ac350. I agree that it's OK to remove; it's exceedingly unlikely that anyone was relying on it pre-1.6, and 'unsafe' should give us that kind of leeway, http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager-test.cc@492 PS1, Line 492: FLAGS_env_inject_lock_failure_globs = ""; Wouldn't a new scope and a flagsaver be more idiomatic? http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager.cc@391 PS1, Line 391: CheckAndFixPermissions(); We ought to gate this behind locking too. It shouldn't affect an existing tserver (although what if one of the tservers is running with a different umask? Maybe?), but it's a destructive operation and so we should get the locks first. -- To view, visit http://gerrit.cloudera.org:8080/9596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3471c8ce00e77fa1712ea518f6ab281864a08d Gerrit-Change-Number: 9596 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 13 Mar 2018 17:30:28 +0000 Gerrit-HasComments: Yes
