Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9596 )
Change subject: KUDU-2153. Servers should not delete tmp files until after locking directories ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager-test.cc@492 PS1, Line 492: } > Wouldn't a new scope and a flagsaver be more idiomatic? Done http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/9596/1/src/kudu/fs/fs_manager.cc@391 PS1, Line 391: if (!dd_manager_) { > Do we need the right permissions to go about locking? If not, then +1 Done. We should have fine permissions. The "check permissions" is mostly to ensure that they aren't too _open_. iirc we added it when we added more security support, to ensure that people didn't accidentally run with world-readable data files and think they were secure. -- To view, visit http://gerrit.cloudera.org:8080/9596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3471c8ce00e77fa1712ea518f6ab281864a08d Gerrit-Change-Number: 9596 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 13 Mar 2018 21:45:42 +0000 Gerrit-HasComments: Yes
