Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9625 )
Change subject: [consensus] FAILED_UNRECOVERABLE replica health status ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9625/3/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: http://gerrit.cloudera.org:8080/#/c/9625/3/src/kudu/consensus/metadata.proto@46 PS3, Line 46: an > nit: a Done http://gerrit.cloudera.org:8080/#/c/9625/3/src/kudu/consensus/metadata.proto@55 PS3, Line 55: be back > nit: return to a HEALTHY state Done http://gerrit.cloudera.org:8080/#/c/9625/3/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/9625/3/src/kudu/consensus/quorum_util-test.cc@695 PS3, Line 695: { > correct me if I'm wrong but I think we also want a test case for: You are absolutely right -- I added a couple of test cases into the ShouldEvictReplicaNonVoters scenario. http://gerrit.cloudera.org:8080/#/c/9625/3/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: http://gerrit.cloudera.org:8080/#/c/9625/3/src/kudu/consensus/quorum_util.cc@610 PS3, Line 610: has_non_voter_failed |= failed; > what about failed_unrecoverable for non-voters? Good point, indeed: I addressed that as well. -- To view, visit http://gerrit.cloudera.org:8080/9625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35637c5bda6681b732dbc2bbf94b9d4258b12095 Gerrit-Change-Number: 9625 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 14 Mar 2018 19:21:40 +0000 Gerrit-HasComments: Yes
