Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9625 )
Change subject: [consensus] FAILED_UNRECOVERABLE replica health status ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9625/4/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/9625/4/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1481 PS4, Line 1481: } : : // The leader replica marks the non-responsive replica as failed after it : // realizes the replica would not be able to catch up, and the catalog : // manager evicts the failed replica right away since it failed in an : // unrecoverable way. : bool has_leader = false; : TabletLocationsPB tablet_locations; > It's a good observation -- I took care of that. I'm probably missing something, but I don't see what's preventing kReplicasNum voters to occur (due to promotion) before this loop notices. -- To view, visit http://gerrit.cloudera.org:8080/9625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35637c5bda6681b732dbc2bbf94b9d4258b12095 Gerrit-Change-Number: 9625 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 14 Mar 2018 23:31:01 +0000 Gerrit-HasComments: Yes
